Item Property Costs showing up wrong in toolset

For toolset tutorials as well as question and answers.
Locked
User avatar
Riotnrrd
DMA's Technical Liaison
Posts: 1682
Joined: Sat Jan 03, 2004 2:04 pm

Item Property Costs showing up wrong in toolset

Post by Riotnrrd »

Scroll Base Prices do not appear to display correctly in the toolset.

Used to be, scroll Base Costs as shown in the Item Properties in the toolset were determined thusly:

baseitems.2da gives the 'Base Item Multiplier'
iprp_chargecost.2da gives the 'Charge Cost'
iprp_spells.2da gives the 'Spell Cost'

And the Base Price = Base Item Multiplier * Charge Cost * Spell Cost

Example: Scroll of Mage Armor (CL 2), with values from ALFA 2das
1 Charge per use Charge Cost = .278
Scroll Base Item Multiplier = .25
Spell Cost = 720
.278 * .25 * 720 = 50, which is the correct Base Price for this scroll

Problem is, the Item Properties Base Cost in the toolset doesn't show 50. It shows 72.

In further experimentation, the Base Cost that shows up is actually 44% higher than it should be. This implies here's an additional scaling factor of 1.44 in there somewhere.

Anyone know why this is? Its confusing and could lead to errors (and judging from the scroll prices Ive seen around ALFA, it does).
User avatar
hollyfant
Staff Head on a Pike - Standards
Posts: 3481
Joined: Mon Oct 24, 2005 3:33 pm
Location: the Netherworl... lands! I meant the Netherlands.

Re: Item Property Costs showing up wrong in toolset

Post by hollyfant »

Won't globally correcting this throw the manually adjusted prices off kilter?

Coding is like sex: one mistake, and you'll have to support it for life.
t-ice
Dungeon Master
Posts: 2106
Joined: Fri Apr 17, 2009 6:24 pm

Re: Item Property Costs showing up wrong in toolset

Post by t-ice »

If it does, the "good" side is that it won't affect items already in store. To my understanding those are instanced from blueprints when the shop is tooled, as opposed to pointers to the prints themselves.
User avatar
Riotnrrd
DMA's Technical Liaison
Posts: 1682
Joined: Sat Jan 03, 2004 2:04 pm

Re: Item Property Costs showing up wrong in toolset

Post by Riotnrrd »

Something isn't adding up, I want to know why. That's all.
User avatar
AcadiusLost
Chosen of Forumamus, God of Forums
Posts: 5061
Joined: Tue Oct 19, 2004 8:38 am
Location: Montara, CA [GMT -8]
Contact:

Re: Item Property Costs showing up wrong in toolset

Post by AcadiusLost »

Could be a toolset display error; I know a few 2DA files in haks fail to be taken into account by the toolset without overrides, and I seem to remember some of the itemcost ones fit into that category. Have you checked the scroll costs in a store via the player or DM client? That's the best test of how they'll show up ingame. Other option is extracting the pricing 2das (or all the 2das in the alfa2_2da.hak) into /override prior to reopening toolset and your module, then checking pricing via toolset again.

AFAIK the scroll pricing should be correct with no price adjustments (assuming correct baseitemtype: scroll, single Cast Spell itemproperty, etc); I did pretty extensive retooling to ensure this a long time back.

Individual spell misspricing could still be an issue from data-entry error, but there should be no systemic problems.
User avatar
Riotnrrd
DMA's Technical Liaison
Posts: 1682
Joined: Sat Jan 03, 2004 2:04 pm

Re: Item Property Costs showing up wrong in toolset

Post by Riotnrrd »

Thanks AL, dropping all of the 2das into the folder showed the correct price for scrolls.

I believe the baseitems.2da magicwand multiplier is slightly incorrect. It should be 2.08333 instead of 2.0825. This would make wands price exactly right.

I'll have to bug you with some further questions related to overrides, if I can catch you on chat!
Locked